Skip to content

Import Atmel SAML21, SAMR34 and SAMR35 header files from ASF library #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2022
Merged

Import Atmel SAML21, SAMR34 and SAMR35 header files from ASF library #17

merged 5 commits into from
Apr 19, 2022
+98,828 −0

Conversation

@attie-argentum
Copy link
Member

@attie-argentum attie-argentum commented Dec 17, 2021 •
edited
Loading

Zephyr support for these parts is following, but depends on this PR.

This PR supersedes #11, which can likely be closed now.

@attie-argentum attie-argentum mentioned this pull request Dec 17, 2021
Merged
@attie-argentum attie-argentum changed the title Import Atmel SAML21 header files from ASF library Import Atmel SAML21, SAMR34 and SAMR35 header files from ASF library Jan 5, 2022
@attie-argentum
Copy link
Member Author

attie-argentum commented Jan 5, 2022

@stephanosio / @nandojve / @mnkp - any chance we can look at getting this merged?

@attie-argentum
Copy link
Member Author

attie-argentum commented Feb 2, 2022 •
edited
Loading

@stephanosio / @nandojve / @mnkp - Hi all, what's the typical process here? Does zephyrproject-rtos/zephyr#41308 need to be approved before this will be considered, or can we get this merged and on the way?

@nandojve
Copy link
Member

nandojve commented Feb 2, 2022

Hi @attie-argentum ,

The hal code is merged when people is reviewing 41308. Someone need check why scancode is not happy. Did you look at it?
Right now, Zephyr is in stabilization phase due to new v3.0.0 release, see release process. This means that only documentation and bug fixes will be accepted. We need wait next merge window to move forward with new SoC and/or features.

@attie-argentum
Copy link
Member Author

attie-argentum commented Feb 2, 2022 •
edited
Loading

Hi @nandojve ,

Understood, thanks very much.

Re scancode: This appears to be a license issue - other existing files will likely fail this check too (e.g: samd21/component-version.h is also apache-2.0)... I'm not comfortable forcibly relicensing these files to bsd-x11 just to get the check to pass, and this doesn't appear to have been done in the past...

@stephanosio stephanosio mentioned this pull request Feb 3, 2022
Closed
stephanosio
stephanosio approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR, in itself, looks ok.

Re scancode: This appears to be a license issue - other existing files will likely fail this check too (e.g: samd21/component-version.h is also apache-2.0)... I'm not comfortable forcibly relicensing these files to bsd-x11 just to get the check to pass, and this doesn't appear to have been done in the past...

The failure does not have to do with the apache-2.0 licensed ones, but rather with the ones that supposedly have "non-permissive" licenses:

...
* scan/asf/sam0/include/saml21/saml21g17b.h has non-permissive license: nokos-1.0a
...
* scan/asf/sam0/include/saml21/component/ac.h has non-permissive license: elastic-license-2018
...

Since it looks like those are mis-detections and all files are licensed Apache 2.0, the scancode failure can be ignored.

@attie-argentum
Copy link
Member Author

attie-argentum commented Feb 3, 2022 •
edited
Loading

rather with the ones that supposedly have "non-permissive" licenses
looks like those are mis-detections and all files are licensed Apache 2.0, the scancode failure can be ignored

Ah, understood - thanks!

@attie-argentum
Copy link
Member Author

attie-argentum commented Feb 25, 2022

Rebase

@nandojve
Copy link
Member

nandojve commented Mar 29, 2022 •
edited
Loading

Hi @attie-argentum ,

Please, rebase your code and:

1- check this commit 45cb8f8 and make sure you version not suffer same problem
2 - Make sure you are sending a version with Unix Line Feed: find * type f -print0 | xargs -0 dos2unix -k
3 - you need add pinconfig files + headers because now all drivers are using pinctrl API. You can look at pinconfig README for guidance.

@attie-argentum
Copy link
Member Author

attie-argentum commented Mar 29, 2022

Thanks @nandojve - I'm hoping to work on this soon, and I'll check your points.

Very well done with zephyrproject-rtos/zephyr#43731 - I'm planning to follow suit with both this and zephyrproject-rtos/zephyr#41308.

@attie-argentum
ext: Import Atmel SAML21 header files from ASF library
e0bfbd4 
Atmel Software Framework (ASF) provides a set of low-level header
files that give access to different hardware peripherals of Atmel's
ICs.

Origin: Atmel SAML21 Series Device Support (1.2.125)
License: Apache-2.0
URL: http://packs.download.atmel.com/Atmel.SAML21_DFP.1.2.125.atpack
Purpose: Introduction of ASF for the SAM0 series.
Maintained-by: External

Signed-off-by: Attie Grande <[email protected]>
@attie-argentum
ext: Import Atmel SAMR34 header files from ASF library
bae6f12 
Atmel Software Framework (ASF) provides a set of low-level header
files that give access to different hardware peripherals of Atmel's
ICs.

Origin: Atmel SAMR34 Series Device Support (1.0.11)
License: Apache-2.0
URL: http://packs.download.atmel.com/Atmel.SAMR34_DFP.1.0.11.atpack
Purpose: Introduction of ASF for the SAM0 series.
Maintained-by: External

Signed-off-by: Attie Grande <[email protected]>
@attie-argentum
ext: Import Atmel SAMR35 header files from ASF library
cf87a95 
Atmel Software Framework (ASF) provides a set of low-level header
files that give access to different hardware peripherals of Atmel's
ICs.

Origin: Atmel SAMR35 Series Device Support (1.0.10)
License: Apache-2.0
URL: http://packs.download.atmel.com/Atmel.SAMR35_DFP.1.0.10.atpack
Purpose: Introduction of ASF for the SAM0 series.
Maintained-by: External

Signed-off-by: Attie Grande <[email protected]>
@attie-argentum
Copy link
Member Author

attie-argentum commented Apr 9, 2022

Points 1 & 2 are already resolved... looking in to 3 now.

@attie-argentum attie-argentum force-pushed the saml21 branch 4 times, most recently from 07990c8 to 3fecc85 Compare April 11, 2022 15:08
@attie-argentum
Copy link
Member Author

attie-argentum commented Apr 11, 2022

@nandojve / @stephanosio - I believe this PR is ready for review again, now that the pinctrl stuff is in place.

nandojve
nandojve requested changes Apr 18, 2022
View reviewed changes
Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @attie-argentum,

Please, drop revisions to keep pinconfig generic.

@attie-argentum
Copy link
Member Author

attie-argentum commented Apr 18, 2022

@nandojve thanks - done

nandojve
nandojve requested changes Apr 19, 2022
View reviewed changes
Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @attie-argentum ,

I forget to mention but since the yml file is generic, the revision should not be part of file name. Please, drop revision from both *.yml file names.

I'm ready to approve as soon you send update.

@attie-argentum
pinctrl: sam-l21: Add pinconfigs and include files
fc76591 
Add Atmel SAM0 L21 family of pinconfigs definitions and auto
generated files to be used in pinctrl devicetree files.

Signed-off-by: Attie Grande <[email protected]>
@attie-argentum
pinctrl: sam-r34-r35: Add pinconfigs and include files
6aa10c6 
Add Atmel SAM0 R34/R35 family of pinconfigs definitions and auto
generated files to be used in pinctrl devicetree files.

Signed-off-by: Attie Grande <[email protected]>
@attie-argentum
Copy link
Member Author

attie-argentum commented Apr 19, 2022

Ah yes, my apologies! Done.

nandojve
nandojve approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @attie-argentum !

stephanosio
stephanosio approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@nandojve nandojve merged commit 7518d0b into zephyrproject-rtos:master Apr 19, 2022
@attie-argentum attie-argentum deleted the saml21 branch April 19, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nandojve nandojve nandojve approved these changes

@stephanosio stephanosio stephanosio approved these changes

@mnkp mnkp Awaiting requested review from mnkp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@attie-argentum @nandojve @stephanosio